refactor: Rename add_or_lookup_key_contacts_by_address_list() to add_or_lookup_key_contacts() #7052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/rename.add_or_lookup_key_contacts_by_address_list
branch
from
20612da to
b249be7
Compare
iequidoo
commented
Jul 29, 2025
| &mime_parser.recipients, | ||
| to_member_fingerprints, | ||
| chat_id, | ||
| None, |
There was a problem hiding this comment.
Just to be more explicit, otherwise one need to scroll up to see that chat_id == None
…or_lookup_key_contacts() - It's obvious that addresses are needed to add contacts, so `_by_address_list` looks excessive. - The function only looks up `SELF` by address. - The name was confusing because there's also `lookup_key_contacts_by_address_list()` that actually looks up key contacts by addresses (not only `SELF`).
iequidoo
force-pushed
the
iequidoo/rename.add_or_lookup_key_contacts_by_address_list
branch
from
b249be7 to
ee168f6
Compare
link2xt
reviewed
Jul 30, 2025
Its result isn't needed in all the branches.
iequidoo
force-pushed
the
iequidoo/rename.add_or_lookup_key_contacts_by_address_list
branch
from
ee168f6 to
967f67e
Compare
link2xt
approved these changes
Jul 31, 2025
iequidoo
deleted the
iequidoo/rename.add_or_lookup_key_contacts_by_address_list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.